fix: replace --dry-run flag with --confirm for prune-archived#12
Merged
fix: replace --dry-run flag with --confirm for prune-archived#12
Conversation
The --dry-run boolean flag (default true) was unusable because Cobra boolean flags require --flag=false syntax (with =), and --flag false (with space) silently ignores the value. Replace with a --confirm flag (default false) so dry-run is the implicit default and users opt in to deletion with --confirm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dry-run(defaulttrue) with--confirm(defaultfalse) on theprune-archivedsubcommand--dry-run false(with space) silently ignored the value due to Cobra boolean flag parsing requiring=syntax--confirmflagTest plan
github-pokemon prune-archived --org <org> --path <path>— should show dry-run outputgithub-pokemon prune-archived --org <org> --path <path> --confirm— should actually remove archived repos--helpshows updated flag description