Skip to content

Moved prelaunch steps to "install dependencies" option#674

Closed
unbelievableflavour wants to merge 1 commit intoutkarshdalal:masterfrom
unbelievableflavour:vcredist-auto-install
Closed

Moved prelaunch steps to "install dependencies" option#674
unbelievableflavour wants to merge 1 commit intoutkarshdalal:masterfrom
unbelievableflavour:vcredist-auto-install

Conversation

@unbelievableflavour
Copy link
Contributor

@unbelievableflavour unbelievableflavour commented Feb 27, 2026

This separate "install dependencies" to a executable phase before launch phase. Causing them to install the vc redists (and other prelaunchsteps) in the container instead of wine command This will make them actually create registry keys.

@unbelievableflavour unbelievableflavour marked this pull request as draft February 27, 2026 23:01
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 12 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="app/src/main/java/app/gamenative/utils/PreLaunchSteps.kt">

<violation number="1" location="app/src/main/java/app/gamenative/utils/PreLaunchSteps.kt:41">
P2: buildChain always appends a trailing " & " but the only call site executes the chain directly, leaving a dangling command separator that can trigger a cmd syntax error.</violation>
</file>

<file name="app/src/main/java/app/gamenative/ui/PluviaMain.kt">

<violation number="1" location="app/src/main/java/app/gamenative/ui/PluviaMain.kt:1083">
P2: Changing XServer’s route to a query-template breaks exact route comparisons elsewhere (e.g., MainViewModel.setCurrentScreen), causing the XServer screen to be misclassified.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant