Moved prelaunch steps to "install dependencies" option#674
Moved prelaunch steps to "install dependencies" option#674unbelievableflavour wants to merge 1 commit intoutkarshdalal:masterfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
2 issues found across 12 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/src/main/java/app/gamenative/utils/PreLaunchSteps.kt">
<violation number="1" location="app/src/main/java/app/gamenative/utils/PreLaunchSteps.kt:41">
P2: buildChain always appends a trailing " & " but the only call site executes the chain directly, leaving a dangling command separator that can trigger a cmd syntax error.</violation>
</file>
<file name="app/src/main/java/app/gamenative/ui/PluviaMain.kt">
<violation number="1" location="app/src/main/java/app/gamenative/ui/PluviaMain.kt:1083">
P2: Changing XServer’s route to a query-template breaks exact route comparisons elsewhere (e.g., MainViewModel.setCurrentScreen), causing the XServer screen to be misclassified.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
4a2fc8e to
433f530
Compare
433f530 to
1a3a7ed
Compare
This separate "install dependencies" to a executable phase before launch phase. Causing them to install the vc redists (and other prelaunchsteps) in the container instead of wine command This will make them actually create registry keys.