feat: Add Ludashi, PUBG and AnTuTu package options#684
feat: Add Ludashi, PUBG and AnTuTu package options#684ribbit384 wants to merge 1 commit intoutkarshdalal:masterfrom
Conversation
📝 WalkthroughWalkthroughTwo Android Gradle modules introduce a "variant" flavor dimension with four product flavors: default, ludashi, antutu, and pubg. Each flavor specifies a distinct applicationId, enabling multiple APK builds with different package identities from a single codebase. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
app/build.gradle.kts (1)
150-155: Avoid usingdefaultas a flavor name — it's a Kotlin reserved keyword.Using
defaultas an identifier in Kotlin DSL can cause parsing issues or require backticks. Consider renaming tostandard,base, ororiginal.♻️ Suggested fix
productFlavors { - create("default") { + create("standard") { dimension = "variant" // Inherits applicationId from defaultConfig ("app.gamenative") isDefault = true }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/build.gradle.kts` around lines 150 - 155, The product flavor name "default" is a Kotlin reserved word and can cause DSL parsing issues; update the productFlavors.create("default") usage to a non-reserved identifier (e.g., "standard" or "base") and update any references to that flavor elsewhere (build variants or signingConfigs) to match the new name; ensure the create(...) call and any places that referenced "default" (productFlavors, buildVariant names) are consistently renamed so the Kotlin DSL no longer requires backticks.ubuntufs/build.gradle.kts (1)
14-21: Avoid usingdefaultas a flavor name — it's a Kotlin reserved keyword.Using
defaultas an identifier in Kotlin DSL can cause parsing issues or require backticks. Consider renaming tostandard,base, ororiginal.♻️ Suggested fix
flavorDimensions += "variant" productFlavors { - create("default") { dimension = "variant" } + create("standard") { dimension = "variant" } create("ludashi") { dimension = "variant" } create("antutu") { dimension = "variant" } create("pubg") { dimension = "variant" } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ubuntufs/build.gradle.kts` around lines 14 - 21, The product flavor name "default" in the productFlavors block is a Kotlin reserved word and can cause DSL parsing issues; rename the create("default") flavor to a non-reserved identifier (e.g., "standard" or "base") inside the productFlavors block and update any other build logic or references that rely on the "default" flavor name (tasks, variant filters, manifest placeholders, signingConfigs, etc.) so they use the new identifier; ensure flavorDimensions and the other create(...) calls remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/build.gradle.kts`:
- Around line 156-167: Replace the third‑party package IDs used as applicationId
in the productFlavor blocks for "ludashi", "antutu", and "pubg" with
project-specific, non‑infringing identifiers (e.g.,
com.yourorg.projectname.variant or a clearly documented placeholder), and add a
brief comment above those create("ludashi"/"antutu"/"pubg") blocks documenting
the legitimate purpose for these flavors (if any) so maintainers can review;
ensure the unique symbols to change are the product flavor definitions
create("ludashi"), create("antutu"), and create("pubg") in the build.gradle.kts
and do not retain com.ludashi.benchmark, com.antutu.ABenchMark, or
com.tencent.ig as applicationId values.
---
Nitpick comments:
In `@app/build.gradle.kts`:
- Around line 150-155: The product flavor name "default" is a Kotlin reserved
word and can cause DSL parsing issues; update the
productFlavors.create("default") usage to a non-reserved identifier (e.g.,
"standard" or "base") and update any references to that flavor elsewhere (build
variants or signingConfigs) to match the new name; ensure the create(...) call
and any places that referenced "default" (productFlavors, buildVariant names)
are consistently renamed so the Kotlin DSL no longer requires backticks.
In `@ubuntufs/build.gradle.kts`:
- Around line 14-21: The product flavor name "default" in the productFlavors
block is a Kotlin reserved word and can cause DSL parsing issues; rename the
create("default") flavor to a non-reserved identifier (e.g., "standard" or
"base") inside the productFlavors block and update any other build logic or
references that rely on the "default" flavor name (tasks, variant filters,
manifest placeholders, signingConfigs, etc.) so they use the new identifier;
ensure flavorDimensions and the other create(...) calls remain unchanged.
| create("ludashi") { | ||
| dimension = "variant" | ||
| applicationId = "com.ludashi.benchmark" | ||
| } | ||
| create("antutu") { | ||
| dimension = "variant" | ||
| applicationId = "com.antutu.ABenchMark" | ||
| } | ||
| create("pubg") { | ||
| dimension = "variant" | ||
| applicationId = "com.tencent.ig" | ||
| } |
There was a problem hiding this comment.
Using package names of third-party apps raises serious policy and legal concerns.
The applicationId values for ludashi, antutu, and pubg flavors are package names belonging to well-known third-party applications:
com.ludashi.benchmark— Ludashi/Master Lu benchmarkcom.antutu.ABenchMark— AnTuTu benchmarkcom.tencent.ig— PUBG Mobile
Building APKs that impersonate other apps' package identities:
- Policy risk: Violates Google Play policies and could result in account/app bans
- Legal risk: Potential trademark infringement with original app owners
- Ethical concern: Commonly used for benchmark score manipulation by device manufacturers
Given the author's note ("Not sure how everyone feels about this"), I'd strongly recommend discussing with project maintainers before merging, and documenting the intended legitimate use case if there is one.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@app/build.gradle.kts` around lines 156 - 167, Replace the third‑party package
IDs used as applicationId in the productFlavor blocks for "ludashi", "antutu",
and "pubg" with project-specific, non‑infringing identifiers (e.g.,
com.yourorg.projectname.variant or a clearly documented placeholder), and add a
brief comment above those create("ludashi"/"antutu"/"pubg") blocks documenting
the legitimate purpose for these flavors (if any) so maintainers can review;
ensure the unique symbols to change are the product flavor definitions
create("ludashi"), create("antutu"), and create("pubg") in the build.gradle.kts
and do not retain com.ludashi.benchmark, com.antutu.ABenchMark, or
com.tencent.ig as applicationId values.
|
+1, should probably also update the gh actions as well so these are added to releases |
|
Forgot to mark this as draft, far from done yet. |
|
Per project lead this feature is not wanted at all. PR closed. |
2 participants
Not sure how everyone feels about this. But open to not merging if it's not wanted.
Summary by cubic
Adds a "variant" flavor dimension and new product flavors so we can build package-specific APKs for Ludashi, AnTuTu, and PUBG alongside the default. The app and ubuntufs modules now share the same flavors, with applicationIds: app.gamenative (default), com.ludashi.benchmark, com.antutu.ABenchMark, and com.tencent.ig.
Written for commit 2a6807f. Summary will update on new commits.
Summary by CodeRabbit