Skip to content

cp missing missing2 2>/dev/full does not abort#10596

Closed
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:cp-abort
Closed

cp missing missing2 2>/dev/full does not abort#10596
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:cp-abort

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Jan 30, 2026

Closes #10595

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@ChrisDryden
Copy link
Copy Markdown
Collaborator

When strategizing about these types of fixes, I think this one is risky because we are changing the behaviour of all of the utilities that use this while only validating this specific utility. I was thinking it would be better to move them over with tests that show the functionality that we are trying to replicate so that going forward we will make sure that we never make changes that mess with that behavior.

Would it be possible to make a new macro for this to keep all of the other utilities keeping the same behaviour so that when we migrate the other utilities we can make sure to have regression checks?

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Jan 30, 2026

What name? show_error_safe!? No idea...

@oech3 oech3 force-pushed the cp-abort branch 3 times, most recently from e4d8bbc to 60345a4 Compare January 31, 2026 02:15
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Jan 31, 2026

I made print_error!.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Jan 31, 2026

I think it is worth to try changing the macro directly for #9810

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Jan 31, 2026

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Feb 3, 2026

fixed macro

@oech3 oech3 closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cp missing missing2 2>/dev/full SIGABRT

2 participants