ls: Remove potentially redundant syscall, only use direntries for file types#11423
Open
kimono-koans wants to merge 16 commits intouutils:mainfrom
Open
ls: Remove potentially redundant syscall, only use direntries for file types#11423kimono-koans wants to merge 16 commits intouutils:mainfrom
kimono-koans wants to merge 16 commits intouutils:mainfrom
Conversation
Merging this PR will degrade performance by 20.22%
Performance Changes
Comparing Footnotes
|
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, we were requesting symlink_metadata before proceeding to the color_name fn, and I've also completely eliminated the need to hold onto DirEntrys within the PathData struct. Statx calls are faster.