uucore: support realtime signals (RTMIN/RTMAX) in signal_by_name_or_value#11425
Open
kevinburkesegment wants to merge 2 commits intouutils:mainfrom
Open
uucore: support realtime signals (RTMIN/RTMAX) in signal_by_name_or_value#11425kevinburkesegment wants to merge 2 commits intouutils:mainfrom
kevinburkesegment wants to merge 2 commits intouutils:mainfrom
Conversation
…alue `signal_by_name_or_value()` only looked up signals from the static ALL_SIGNALS array, which doesn't include realtime signals. This caused `timeout -s RTMAX`, `kill -s RTMIN`, and `env --default-signal=RTMAX` to reject valid signal names. Extend the function to fall back to realtime_signal_bounds() for both name lookups and numeric values in the realtime range, matching the behavior already present in signal_list_value_by_name_or_number(). Also fix timeout's report_if_verbose() to use signal_list_name_by_value instead of signal_name_by_value, so verbose output doesn't panic for realtime signal numbers. Fixes GNU test: tests/env/env-signal-handler.sh Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kevinburkesegment
force-pushed
the
fix-rtmax-signal
branch
from
3c9c91d to
f0e5d7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signal_by_name_or_value()only looked up signals from the static ALL_SIGNALS array, which doesn't include realtime signals. This causedtimeout -s RTMAX,kill -s RTMIN, andenv --default-signal=RTMAXto reject valid signal names.Extend the function to fall back to realtime_signal_bounds() for both name lookups and numeric values in the realtime range, matching the behavior already present in signal_list_value_by_name_or_number().
Also fix timeout's report_if_verbose() to use signal_list_name_by_value instead of signal_name_by_value, so verbose output doesn't panic for realtime signal numbers.
Fixes GNU test: tests/env/env-signal-handler.sh