rm: use "traversal failed" message when readdir fails during recursive removal#11427
Open
kevinburkesegment wants to merge 3 commits intouutils:mainfrom
Open
rm: use "traversal failed" message when readdir fails during recursive removal#11427kevinburkesegment wants to merge 3 commits intouutils:mainfrom
kevinburkesegment wants to merge 3 commits intouutils:mainfrom
Conversation
…e removal When readdir fails mid-traversal (e.g., due to I/O errors), GNU rm reports "traversal failed: <dir>" rather than "cannot remove '<dir>'". Update the error handling in safe_remove_dir_recursive_impl to match this behavior. Fixes GNU test: tests/rm/rm-readdir-fail.sh Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kevinburkesegment
force-pushed
the
rm-traversal-failed
branch
from
15ad1ee to
ed919a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When readdir fails mid-traversal (e.g., due to I/O errors), GNU rm reports "traversal failed:
" rather than "cannot remove ''". Update the error handling in safe_remove_dir_recursive_impl to match this behavior.Fixes GNU test: tests/rm/rm-readdir-fail.sh