Skip to content

fix: supports cross-platform building and 32-bit#11452

Open
YumeYuka wants to merge 3 commits intouutils:mainfrom
OOM-WG:main
Open

fix: supports cross-platform building and 32-bit#11452
YumeYuka wants to merge 3 commits intouutils:mainfrom
OOM-WG:main

Conversation

@YumeYuka
Copy link

Commit By @ShIroRRen

@oech3

This comment was marked as resolved.

@ShIroRRen
Copy link

Windows does not support stdbuf. cygwin support is enough.

Just to make the if more correct, although it won't build it

@oech3

This comment was marked as resolved.

@oech3

This comment was marked as resolved.

@ShIroRRen
Copy link

You should add

#[cfg(not(unix))]
compile_error!("stdbuf is not supported on the target");

and remove stdbuf-error-command-not-supported from ftl files instead.

I added it

@oech3
Copy link
Contributor

oech3 commented Mar 22, 2026

Does this PR cover #11311 and #11428 ? cc @0323pin

@sylvestre
Copy link
Contributor

plenty of jobs are failing

@ShIroRRen
Copy link

plenty of jobs are failing

Because of the feature, I missed one during testing, and now I've added it.

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants