uucore: deduplicate CharByte From implementations using macro#11473
Open
ppmpreetham wants to merge 2 commits intouutils:mainfrom
Open
uucore: deduplicate CharByte From implementations using macro#11473ppmpreetham wants to merge 2 commits intouutils:mainfrom
ppmpreetham wants to merge 2 commits intouutils:mainfrom
Conversation
Contributor
|
Sorry but why? :) |
Author
|
It makes the code more readable, and removes redundant impl codes :) |
Contributor
|
sorry but i am not sure it is worse it ? :) |
Author
|
It actually makes it better ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace repetitive
Fromimplementations forCharBytewith a reusable macro.This introduces a new macro
impl_from_for_enum!inuucore::macrosand uses itto generate the existing
From<char>,From<u8>, andFrom<&u8>implementations.Motivation
The previous implementation manually defined multiple
Fromimpls forCharBytethat followed an identical pattern. This change removes duplication while keeping
the behavior unchanged.
The macro is designed to be reusable for similar enum patterns elsewhere in the codebase.
Changes
impl_from_for_enum!macro touucore::macrosFromimplementations forCharBytewith macro usageExample
Before:
After:
Notes
From<&T>via, ref.map(CharByte::from))Testing
Checklist