Skip to content

Fix/issue 11315#11478

Open
baa-ableton wants to merge 2 commits intouutils:mainfrom
baa-ableton:fix/issue-11315
Open

Fix/issue 11315#11478
baa-ableton wants to merge 2 commits intouutils:mainfrom
baa-ableton:fix/issue-11315

Conversation

@baa-ableton
Copy link
Contributor

No description provided.

Replace manual string parsing of --length with clap's built-in usize value_parser. Use value_source to distinguish user-provided values from the default, so Option<usize> semantics are preserved without needing to handle Option<&str> chains.
Clap's usize parser now handles NaN and overflow inputs, producing 'invalid value' errors instead of 'invalid length'. Leading zeros like '00' and '01' parse to their canonical usize values.
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cksum/b2sum. tests/cksum/b2sum is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-sha3. tests/cksum/cksum-sha3 is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 24, 2026

Merging this PR will degrade performance by 5.33%

❌ 13 regressed benchmarks
✅ 287 untouched benchmarks
⏩ 46 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory cksum_sha1 41.6 KB 44 KB -5.31%
Memory cksum_crc 41.8 KB 44.1 KB -5.29%
Memory cksum_sha256 41.7 KB 44 KB -5.31%
Memory cksum_sha512 41.9 KB 44.2 KB -5.29%
Memory cksum_crc32b 41.8 KB 44.1 KB -5.3%
Memory cksum_sha224 41.7 KB 44 KB -5.31%
Memory cksum_sha384 41.8 KB 44.2 KB -5.29%
Memory cksum_sysv 41.5 KB 43.8 KB -5.33%
Memory cksum_blake2b 41.9 KB 44.2 KB -5.29%
Memory cksum_blake3 43.5 KB 45.8 KB -5.1%
Memory cksum_md5 41.6 KB 44 KB -5.32%
Memory cksum_bsd 41.5 KB 43.8 KB -5.33%
Memory cksum_sm3 41.7 KB 44 KB -5.31%

Comparing baa-ableton:fix/issue-11315 (b2fa7df) with main (e0f0318)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
Copy link
Contributor

oech3 commented Mar 25, 2026

Still many Some() are kept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants