fix: Override bind items for combobox#8803
Merged
Conversation
github-project-automation
Bot
moved this to 🔎Iteration reviews
in Vaadin Flow | Hilla | Kits ongoing work
tltv
approved these changes
Mar 5, 2026
|
DiegoCardoso
approved these changes
Mar 9, 2026
Contributor
DiegoCardoso
left a comment
DiegoCardoso
left a comment
There was a problem hiding this comment.
Adding this test fails when it shouldn't:
@Test(expected = BindingActiveException.class)
public void bindItems_thenSetItems_throws() {
var listSignal = new ValueSignal<>(List.of(new ValueSignal<>("Alice")));
comboBox.bindItems(listSignal);
ui.add(comboBox);
comboBox.setItems("Bob");
}But, as discussed internally, it should be addressed separately.
github-project-automation
Bot
moved this from 🔎Iteration reviews
to Done
in Vaadin Flow | Hilla | Kits ongoing work
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
ComboBox requires filter convertor and thus fails for generic data provider. This PR adds: overload for bindItems that takes the converter overload for bindItems that uses default items filter (uses items label generator and contains) unit tests for both methods E2E test. E2E test uses a custom equality checker for value signal and re-uses the Person entity class which equality is based in ID: ComboBox uses ID for refreshing items, whereas item signals should use some other equality (first name + last name), because otherwise signals skip calling the effects and value updates if they see equal values. Related-to vaadin/flow#23659
mshabarov
added a commit
that referenced
this pull request
Mar 9, 2026
ComboBox requires filter convertor and thus fails for generic data provider. This PR adds: overload for bindItems that takes the converter overload for bindItems that uses default items filter (uses items label generator and contains) unit tests for both methods E2E test. E2E test uses a custom equality checker for value signal and re-uses the Person entity class which equality is based in ID: ComboBox uses ID for refreshing items, whereas item signals should use some other equality (first name + last name), because otherwise signals skip calling the effects and value updates if they see equal values. Related-to vaadin/flow#23659 Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Collaborator
|
This ticket/PR has been released with Vaadin 25.2.0-alpha2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComboBox requires filter convertor and thus fails for generic data provider. This PR adds:
E2E test uses a custom equality checker for value signal and re-uses the
Personentity class which equality is based in ID:ComboBoxuses ID for refreshing items, whereas item signals should use some other equality (first name + last name), because otherwise signals skip calling the effects and value updates if they see equal values.Related-to vaadin/flow#23659