Add changes to support pattern uninstall#88
Merged
mbaldessari merged 3 commits intovalidatedpatterns:mainfrom Feb 5, 2026
Merged
Add changes to support pattern uninstall#88mbaldessari merged 3 commits intovalidatedpatterns:mainfrom
mbaldessari merged 3 commits intovalidatedpatterns:mainfrom
Conversation
We want to pass a different value to child charts if we are on the hub, since we want acm to first remove all the child applications before we actually remove acm. Change it to a string, and pass directly to child charts. Acm chart will handle further logic, from clustergroup we only care if we need to render the applications or not.
deletePattern can now only be a string, we only want to remove the apps for a specific phase(DeleteChildApps), all other deletion phase we need the apps to be rendered.
darkdoc
force-pushed
the
uninstall_poc
branch
from
05b1f28 to
c524364
Compare
deletePattern can now only be a string, we only want to remove the apps for a specific phase(DeleteChildApps), all other deletion phase we need the apps to be rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to pass a different value to child charts if we are on the
hub, since we want acm to first remove all the child applications
before we actually remove acm.
Change it to a string, and pass directly to child charts.
Acm chart will handle further logic, from clustergroup we only care if
we need to render the applications or not.