fix variable names of the proposed solution

[mimoun-ellebbar]

Pre-flight Checklist

• Are all the features in this PR tested?
• Have other features this PR touches also been tested?
• Has the code been formatted for consistency and readability?
• Did you also update related documentation and tooling, such as .readme or tests?

Overview

There’s a bug in the into queries exercise solution. A line of code converts an input variable from an array into a string, but later the solution tries to use that same variable as if it were still an array. Since the original data gets overwritten, the program will crash

Context

Requirements addressed:

• Rename the variable created after converting the array to a string, instead of overwriting the original input.
• Update all usage points to reference the new output variable.
• Preserve the original input type to prevent incorrect usage and runtime errors.

Screenshots

To:

[mmcev106]

@ChemiKyle, would you like to review this since you wrote it?

[ChemiKyle]

Good catch @mimoun-ellebbar! Your proposed solution works for n = 1, I added a suggestion to expand support to more than 1 user. 2 infinite improvements in 2 commits!

[mimoun-ellebbar]

Appreciate it @ChemiKyle, but the function logic still unchanged, i just wrangled the variable names so the function would continue to use each variable's data for the right context

[ChemiKyle]

Happy to approve once these 2 changes are committed.

@mimoun-ellebbar we typically expect DataCore team members to merge their own PRs after approval (as a reviewer, you'll usually only merge PR from a collaborator without write access to a repository).

[ChemiKyle]

Suggested change

	$result = $this->query($sql, [$new_value, $usernames_data]);
	$result = $this->query($sql, [$new_value, $users]);

This needs to be the user array otherwise it only works when only a single user is altered.

[mimoun-ellebbar]

i see what you are saying, but in that case the join/implode logic would be unnecessary, also the $users param would not get accepted, i guess the best approach here, based on source code:

1. get rid of join logic for usernames:
   $usernames_data = implode('", "', $users);
2. change the update to this :

$params = array_merge([$new_value], $users); $result = $this->query($sql, $params);