Skip to content

PDF/A-4. Add new flavours#694

Open
MaximPlusov wants to merge 1 commit intointegrationfrom
pdfa4
Open

PDF/A-4. Add new flavours#694
MaximPlusov wants to merge 1 commit intointegrationfrom
pdfa4

Conversation

@MaximPlusov
Copy link
Contributor

@MaximPlusov MaximPlusov commented Mar 2, 2026

Summary by CodeRabbit

Release Notes

  • New Features
    • Added support for PDF/A-4 2020 edition (ISO 19005-4:2020) with three flavor variants, enabling validation of the latest PDF/A compliance standards for enhanced document archival capabilities.

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

📝 Walkthrough

Walkthrough

Extends the PDFFlavour enum with three new PDF/A-4 variants (PDFA_4_2020, PDFA_4_F_2020, PDFA_4_E_2020) and introduces a corresponding Specification constant ISO_19005_4_2020 to support ISO 19005-4:2020 standard validation.

Changes

Cohort / File(s) Summary
PDF/A-4 Specification Support
src/main/java/org/verapdf/parser/PDFFlavour.java
Added three new PDFFlavour enum constants for PDF/A-4 variants and one new Specification constant mapping to ISO 19005-4:2020 standard.

Possibly related PRs

Poem

🐰 Four new lines, a rabbit's delight,
PDF/A-4 shining so bright,
ISO standards dance and play,
Flavours multiplied today,
Hopping forward, specs take flight!


🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'PDF/A-4. Add new flavours' accurately and concisely describes the main change: adding new PDF/A-4 flavour enum constants to the PDFFlavour class.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pdfa4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/main/java/org/verapdf/parser/PDFFlavour.java (1)

78-79: Clarify the intent of ISO_19005_4 vs ISO_19005_4_2020.

Line 78 introduces a near-duplicate specification identifier. Since isFlavourPart relies on exact enum equality, a short Javadoc/inline note here would prevent accidental misuse and make alias/version intent explicit.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/main/java/org/verapdf/parser/PDFFlavour.java` around lines 78 - 79, Add a
short Javadoc or inline comment next to the PDFFlavour enum entries ISO_19005_4
and ISO_19005_4_2020 clarifying their relationship and intended use (e.g., that
ISO_19005_4_2020 is the 2020 variant and ISO_19005_4 is an alias/legacy
identifier or vice versa) so callers relying on exact equality (such as
isFlavourPart) understand which to use; reference the enum name PDFFlavour and
the enum constants ISO_19005_4 and ISO_19005_4_2020 and mention isFlavourPart to
make the intent explicit.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/main/java/org/verapdf/parser/PDFFlavour.java`:
- Around line 78-79: Add a short Javadoc or inline comment next to the
PDFFlavour enum entries ISO_19005_4 and ISO_19005_4_2020 clarifying their
relationship and intended use (e.g., that ISO_19005_4_2020 is the 2020 variant
and ISO_19005_4 is an alias/legacy identifier or vice versa) so callers relying
on exact equality (such as isFlavourPart) understand which to use; reference the
enum name PDFFlavour and the enum constants ISO_19005_4 and ISO_19005_4_2020 and
mention isFlavourPart to make the intent explicit.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 571e2c3 and 06229c0.

📒 Files selected for processing (1)
  • src/main/java/org/verapdf/parser/PDFFlavour.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant