fix(discord): recover existing thread on 160004 error#280
Open
saschabuehrle wants to merge 1 commit intovercel:mainfrom
Open
fix(discord): recover existing thread on 160004 error#280saschabuehrle wants to merge 1 commit intovercel:mainfrom
saschabuehrle wants to merge 1 commit intovercel:mainfrom
Conversation
Contributor
|
@saschabuehrle is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
#279 —
createDiscordThreadsilently fails when Discord returns error code 160004 ("A thread has already been created for this message"), leavingdiscordThreadIdasundefined. The bot then posts a standalone channel message instead of replying in the existing thread.Fix
Added error recovery inside
createDiscordThreadfor the specific 160004 error code. When Discord reports that a thread already exists for a message, the method now returns the existing thread's ID (which equals the parent message ID in Discord's threading model) instead of letting the error propagate.This handles all call sites at once — both the webhook handler and the gateway handler benefit from the recovery without needing individual catch-block changes.
Other Discord API errors continue to propagate normally.
Testing
Verified that:
NetworkErrorwith "160004" in the message triggers the recovery pathHappy to address any feedback.
Greetings, saschabuehrle