Make DJANGO_SECRET get required to be populated when creating repo#1457
Open
Make DJANGO_SECRET get required to be populated when creating repo#1457
Conversation
msullivan
requested review from
dominiksipowicz,
goncy,
lfades,
lpalmes and
okbel
as code owners
Contributor
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Additional Suggestions:
- The
DJANGO_SECRETenvironment variable that users are prompted to set during deployment is never read by settings.py, which hardcodes an insecure default secret key.
- Environment variable name mismatch: settings.py reads
DJANGO_SECRET_KEYbut all deploy URLs and documentation tell users to setDJANGO_SECRET, so the secret key is never used in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.