chore: bump framework dependencies across packages and workbenches#1433
Open
chore: bump framework dependencies across packages and workbenches#1433
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Contributor
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (1 failed)vite (1 failed):
🌍 Community Worlds (56 failed)mongodb (3 failed):
redis (2 failed):
turso (51 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
📊 Benchmark Results
workflow with no steps▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 1 step▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 10 sequential steps▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 sequential steps▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 50 sequential steps▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.all with 10 concurrent steps▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 25 concurrent steps▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.all with 50 concurrent steps▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 10 concurrent steps▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 25 concurrent steps▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 50 concurrent steps▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Stream Benchmarks (includes TTFB metrics)workflow with stream▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
The new nitro beta removed `nitro/~internal/runtime/plugin` and exports `definePlugin` from the main `nitro` entry instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s workbench examples and internal integrations to align with newer framework/tooling versions (notably Nitro v3 beta), and adjusts build configuration to support workspace imports and avoid dev reload issues.
Changes:
- Bump framework/tooling dependencies across multiple workbench examples (Nuxt, SvelteKit, Next, Nitro, etc.) and workspace catalog (
nitro). - Update Nitro v3 plugin example + docs to use
definePlugininstead of internaldefineNitroPluginimport. - Adjust
workflow/nitromodule to externalize the.nitro/workflowbuild output via a Rollupexternalwrapper; add a Vite alias for@repo.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workbench/vite/vite.config.ts | Adds @repo alias to resolve workspace imports in the Vite example. |
| workbench/sveltekit/package.json | Updates SvelteKit/Svelte and adapter versions. |
| workbench/nuxt/package.json | Updates Nuxt version used by the Nuxt workbench. |
| workbench/nitro-v3/plugins/start-pg-world.ts | Switches Nitro plugin definition to definePlugin API. |
| workbench/nitro-v3/package.json | Updates Rollup version for Nitro v3 workbench. |
| workbench/nitro-v2/package.json | Updates nitropack version for Nitro v2 workbench. |
| workbench/nextjs-webpack/package.json | Bumps Next version for the webpack workbench. |
| workbench/nextjs-turbopack/package.json | Bumps Next version for the turbopack workbench. |
| workbench/nest/package.json | Updates NestJS + Express dependency versions for Nest workbench. |
| workbench/hono/package.json | Updates Hono version. |
| workbench/fastify/package.json | Updates Fastify version. |
| workbench/express/package.json | Updates Express version. |
| pnpm-workspace.yaml | Updates the workspace catalog nitro version to a v3 beta. |
| packages/nuxt/package.json | Aligns @nuxt/* + nuxt versions used by @workflow/nuxt. |
| packages/nitro/src/index.ts | Changes dev externalization approach to a Rollup external wrapper in rollup:before. |
| packages/next/package.json | Bumps Next version used for @workflow/next development. |
| packages/nest/package.json | Updates NestJS devDependencies used by @workflow/nest. |
| docs/content/docs/deploying/world/postgres-world.mdx | Updates docs snippet to use definePlugin from nitro. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+8
to
+11
| resolve: { | ||
| alias: { | ||
| '@repo': resolve(__dirname, '../..'), | ||
| }, |
Comment on lines
+46
to
+53
| if (typeof prevExternal === 'function') | ||
| return ( | ||
| prevExternal as ( | ||
| id: string, | ||
| ...args: unknown[] | ||
| ) => boolean | null | undefined | ||
| )(id, ...args); | ||
| if (Array.isArray(prevExternal)) return prevExternal.includes(id); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
externals→ rollupexternalconfig)Updated dependencies
Not included (major version bumps for follow-up)
Test plan
🤖 Generated with Claude Code