gcp docker auth will parse the devcontainer dir to look for artifact registry url#315
Merged
gcp docker auth will parse the devcontainer dir to look for artifact registry url#315
Conversation
pantherman594
approved these changes
Feb 3, 2026
Contributor
pantherman594
left a comment
pantherman594
left a comment
There was a problem hiding this comment.
This should be fine for the simple case, but won't work if a devcontainer references some common files outside of the folder (like we do with aou-common and jupyter-common). Why don't we want to auth to all regions?
Long term we could maybe expose artifactRegistryLocations in the UI
Contributor
Author
ya the description says best effort.. it took a long time to list them.. I noticed that it first pull a gcloud image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently we by default docker auth to the user's workspace location. However, users may bring their own image from another region. Instead of authing to all the regions, we parse the devcontainer to make a best effort attempt to get the image url. For backward compatibility, we will still take in the default region of the workspace. this will replace this inline script.