Skip to content

ENG-00000 adding new finalize-with-error #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adranwit merged 1 commit into from
Mar 26, 2026
+15 −0
Merged

ENG-00000 adding new finalize-with-error #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions service/operator/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,16 @@ func (s *Service) finalize(ctx context.Context, ret interface{}, err error, aSes
err = injectorFinalizer.Finalize(ctx, lookup)
return ret, err
}
if finalizer, ok := ret.(state.FinalizerWithError); ok {
finalizeErr := finalizer.Finalize(ctx, err)
if err != nil {
if finalizeErr != nil {
return ret, errors.Join(err, finalizeErr)
}
return ret, err
}
return ret, finalizeErr
}
if err != nil {
return ret, err
}
Expand Down
5 changes: 5 additions & 0 deletions view/state/hook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ type Finalizer interface {
Finalize(ctx context.Context) error
}

// FinaliserWithError is an error-aware finalizer that receives an error from previous steps.
type FinalizerWithError interface {
Finalize(ctx context.Context, err error) error
}

type InjectorFinalizer interface {
Finalize(ctx context.Context, getInjector func(ctx context.Context, path http.Route) (state.Injector, error)) error
}
Loading