Refactor: Replace inline onclick handler with addEventListener in 'dashboard_html.py'#244
Merged
vicsanity623 merged 2 commits intomainfrom Mar 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR modifies the
dashboard_html.pyfile to enhance the event handling mechanism for the 'moveDownBtn' button. Specifically, it replaces the inlineonclickhandler with theaddEventListenermethod. This adjustment is aligned with best practices for JavaScript event handling which promote better separation of concerns and code scalability.Technical Impact
addEventListener, the code becomes easier to maintain and extend. This method allows multiple event listeners to be added to a single DOM element, providing greater flexibility.addEventListenerin future feature implementations where multiple event listeners might be necessary on the same element.No new functionality has been added; this change solely refactors the event handling mechanism for improved code quality.