feat: for customize transforming the segment response data#1572
Open
DreamSkyOk wants to merge 2 commits intovideojs:mainfrom
Open
feat: for customize transforming the segment response data#1572DreamSkyOk wants to merge 2 commits intovideojs:mainfrom
DreamSkyOk wants to merge 2 commits intovideojs:mainfrom
Conversation
Because the 'response' and 'responseText' property from XMLHttpRequest is readonly, add two customize read-write property: videojsCustomizedResponse,videojsCustomizedResponseText to request object. So can customize transform the response data through videojs.Vhs.xhr.onResponse. eg: request.videojsCustomizedResponse=newResponseData
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because the 'response' property from XMLHttpRequest is readonly, can add the customize read-write 'videojsCustomizedResponse' property to request object via the onResponse method.
So can customize transform the response data through videojs.Vhs.xhr.onResponse. eg: request.videojsCustomizedResponse=newResponseData.
Specific Changes proposed
Change generate logic of the newBytes.
Requirements Checklist