Fixed a number of issues, all revolving around VCell locking up under the right (wrong) conditions#1332
Open
CodeByDrescher wants to merge 49 commits intomasterfrom
Open
Fixed a number of issues, all revolving around VCell locking up under the right (wrong) conditions#1332CodeByDrescher wants to merge 49 commits intomasterfrom
CodeByDrescher wants to merge 49 commits intomasterfrom
Conversation
This isn't a solution; more work is needed
Some inversion of control was implemented
may need to synchronize on the specific manager, but not sure.
This isn't a solution; more work is needed
Some inversion of control was implemented
may need to synchronize on the specific manager, but not sure.
…into PrimaryLockUpFix_BadRemoteCall
Contributor
Author
|
Closes #1331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core issue behind this PR: #1331
Fixes introduced in addressing this issue:
ClientTaskDispatcherclass:a)
ClientTaskDispatcher::dispatchAndWaitwill now indefinitely block a dispatched list of tasks, until they are completed.b)
ClientTaskDispatcher::dispatchWithFuturereturns aFuture<Hashtable<String, Object>>object, which can be usedto check if the results are done, or impose a manual timeout on the operation; the underlying mechanism behind
ClientTaskDispatcher::dispatchAndWaitDataAccessException. They are no longer stuck behind a progress dialog that goes on for too long. The window will not close until eitherNois re-selected, or the client is reconnected.