Draft
Conversation
… v2 entity controller.
… load existing entities from the api. This maybe very bad idea. Feature is nice to have, but the implementation of such behaviour should be maybe isolated to separate K8s job ? Lets keep it here for now, and think about better solution in the future. Author suspects that it's not the purpose of the operator to do such a task, much better way could to be define CRD `LoadUpCloudEntitiesJob` or something similar, that would be handle the loading of the entities from the UpC api. - UpCloud Api client tested locally little here before these changes. - Creation of new entities seems to work fine with auto loader. ```shell $ kubectl -n default get objectstorage2s.api.upcloud.com NAME RECONCILESTATE ID CONFIGUREDSTATUS OPERATIONALSTATE REGION UPDATEDAT object-storage-v2-12c5cbc2-3013-491f-a6f4-eeb38edcda4c UP_TO_DATE 12c5cbc2-3013-491f-a6f4-eeb38edcda4c started running europe-1 2023-10-30T21:24:00 ```
…m/visdmin/upcloud-api-kubernetes-operator into object-storage-v2-beta-controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entities and controller to be added:
V1Alpha1ObjectStorage2V1Alpha1ObjectStorage2AccessKeyController features (
V1Alpha1ObjectStorage2):Specwhen state does not matchController features (
V1Alpha1ObjectStorage2AccessKey):Specwhen state does not match (mainlyAccessKey.Enabled)Add
UpCloudApiClientproject and required methods:WIP !!!