Open
Conversation
Give reduce a default set to work with instead of returning nil in all_servers and fresh_cluster_composition_fetched. reduce(&:+) returns nil on empty sets, causing undefined method 'map' for nil when the routing table registry has no handlers. Made-with: Cursor
ktowle
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a
NoMethodErrorthat occurred when internal routing table collections were empty. Thereduce(&:+)method previously returnednilfor empty arrays, leading to errors when further operations were attempted on the result.Initializes the
reduceoperation withSet.newto guarantee that aSetis always returned, even when the input collection is empty. This prevents theNoMethodErrorand correctly accumulates unique server addresses into a set.Fixes VST-98338