Draft
Conversation
hi-ogawa
commented
Mar 2, 2026
Contributor
Author
There was a problem hiding this comment.
I don't remember much about the context of this test, but it looks like tailwind forces reloading on unuded.tsx changes seems reasonable. This looks like independent from SSR framework issue of tailwind, so let's adjust the test case here:
RobinMalfait
added a commit
to tailwindlabs/tailwindcss
that referenced
this pull request
Mar 12, 2026
… css (#19745) <!-- 👋 Hey, thanks for your interest in contributing to Tailwind! **Please ask first before starting work on any significant new features.** It's never a fun experience to have your pull request declined after investing a lot of time and effort into a new feature. To avoid this from happening, we request that contributors create a discussion to first discuss any significant new features. For more info, check out the contributing guide: https://github.com/tailwindlabs/tailwindcss/blob/main/.github/CONTRIBUTING.md --> ## Summary - Closes #19744 - Closes vitejs/vite-plugin-react#1118 - Closes wakujs/waku#1963 The change in #19670 didn't take account for server only modules managed by SSR framework. Forcing full reload for this path breaks server HMR. This PR added a check to determine whether the same modified file has associated modules in a different environment module graph to avoid this. ## Test plan <!-- Explain how you tested your changes. Include the exact commands that you used to verify the change works and include screenshots/screen recordings of the update behavior in the browser if applicable. --> Added an integration test for React router HDR (server loader hmr). This test fails on main. Also the local build is tested on `@vitejs/plugin-rsc` CI and confirmed the fix vitejs/vite-plugin-react#1132 --------- Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing the build from tailwindlabs/tailwindcss#19745.