Skip to content

fix(create): suggest vp run for all templates#1127

Merged
fengmk2 merged 5 commits intovoidzero-dev:mainfrom
hamsurang:fix/vp-create-suggest-vp-run-dev
Mar 25, 2026
Merged

fix(create): suggest vp run for all templates#1127
fengmk2 merged 5 commits intovoidzero-dev:mainfrom
hamsurang:fix/vp-create-suggest-vp-run-dev

Conversation

@jong-kyung
Copy link
Contributor

@jong-kyung jong-kyung commented Mar 24, 2026

Summary

  • Fix vp create to suggest vp run instead of vp dev for non-Vite-native templates (Astro, Nuxt, etc.)
  • Also fix the monorepo path: non-builtin templates now suggest cd <dir> && vp run instead of vp dev <dir>
  • Extract getCreateNextCommand and getNextCommand to utils.ts for testability
  • Add unit tests covering all template type × environment (standalone/monorepo) combinations
  • Add snap tests for monorepo next command verification

Closes #1123

@netlify
Copy link

netlify bot commented Mar 24, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit df39cce
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69c34c1b06a05a00087781d6

@jong-kyung
Copy link
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Always suggest `vp run` after `vp create` regardless of template type,
as suggested by maintainer. This removes template-type and monorepo
branching logic, letting users choose which script to run.

Closes voidzero-dev#1123
@fengmk2 fengmk2 changed the title fix(create): suggest vp run dev for non-Vite-native templates fix(create): suggest vp run for all templates Mar 25, 2026
@fengmk2 fengmk2 merged commit b4e091c into voidzero-dev:main Mar 25, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running vp dev on a new Astro project doesn't work

2 participants