revert: undo per-crate --test-threads=1 split for musl CI#289
Merged
branchseer merged 1 commit intomainfrom Mar 23, 2026
Merged
revert: undo per-crate --test-threads=1 split for musl CI#289branchseer merged 1 commit intomainfrom
branchseer merged 1 commit intomainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts fa42ef9 ("ci: replace global RUST_TEST_THREADS=1 with per-crate --test-threads=1 (#280)").
The change replaced the simple
RUST_TEST_THREADS=1env var withcargo-nextestinstallation and split test commands. This actually regressed musl CI performance:CI Time Comparison (musl job)
The overhead comes from installing
cargo-nextestand running two separatecargoinvocations instead of one.This revert restores the global
RUST_TEST_THREADS=1approach, bringing the musl CI job back to ~4.5 minutes.Test plan
https://claude.ai/code/session_01LGzZqKECkrqipZfmmU9L3U