feat(skills): 为vestack环境添加 minio 文件上传下载支持#546
Open
DawnGuoDev wants to merge 2 commits intovolcengine:mainfrom
Open
feat(skills): 为vestack环境添加 minio 文件上传下载支持#546DawnGuoDev wants to merge 2 commits intovolcengine:mainfrom
DawnGuoDev wants to merge 2 commits intovolcengine:mainfrom
Conversation
添加对vestack环境的支持，包括： 1. 通过GenTempTosObjectUrl/GenTempTosObjectDownloadUrl API获取临时URL 2. 使用requests库实现文件上传下载 3. 使用环境变量AGENTKIT_TOOL_SCHEME配置请求协议
DawnGuoDev
force-pushed
the
feat/vestack-skills-support-minio
branch
from
a64d80c to
fb9c52e
Compare
cuericlee
reviewed
Mar 26, 2026
| save_path=save_path, | ||
| ) | ||
| cloud_provider = (os.getenv("CLOUD_PROVIDER") or "").lower() | ||
| if cloud_provider == "vestack": |
Collaborator
There was a problem hiding this comment.
create new method for vestack?
| if cloud_provider == "vestack": | ||
| import requests | ||
|
|
||
| try: |
Collaborator
There was a problem hiding this comment.
put into new method instead
veadk/skills/utils.py
Outdated
| "InnerTags": {"source": "sandbox"}, | ||
| } | ||
| logger.debug(f"ListSkillsBySpaceId request body: {request_body}") | ||
| scheme = os.getenv("AGENTKIT_TOOL_SCHEME", "https").lower() |
Collaborator
There was a problem hiding this comment.
minio schema? -> CUSTOM_SCHEME, e.g. minio
Author
There was a problem hiding this comment.
这个统一起来吧，针对 vestack 来说，走 top 的请求，都是统一的。AGENTKIT_TOP_SCHEME
将vestack环境下的技能下载逻辑提取到独立函数`_download_skill_via_vestack`中，提高代码复用性 同时将环境变量`AGENTKIT_TOOL_SCHEME`统一更新为`AGENTKIT_TOP_SCHEME`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
添加对vestack环境的支持，包括：