perf[runend]: run_end_bool decompress #6229
Open
+745
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
added
the
do not merge
Merging this PR will degrade performance by 32.46%
Performance Changes
Comparing 
Footnotes
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
joseph-isaacs
added
changelog/performance
github-actions
bot
removed
the
action/benchmark
robert3005
reviewed
Jan 30, 2026
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
Love me some prefilling
joseph-isaacs
changed the title
robert3005
reviewed
Feb 2, 2026
| /// Fills bits in range [start, end) to true using byte-level operations. | ||
| /// Assumes the buffer is pre-initialized to all zeros. | ||
| #[inline(always)] | ||
| fn fill_bits_true(slice: &mut [u8], start: usize, end: usize) { |
Contributor
There was a problem hiding this comment.
we already have append_n logic in BitBufferMut which is very similar to this logic. This logic is even the same between this function and the other logic. Maybe we have BitBuffer expose some set_range, unset_range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
speed up runend bool decompress