Merged
Conversation
Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: blaginin <github@blaginin.me>
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
| .elements() | ||
| .ok_or_else(|| vortex_err!("Expected non-null list"))?; | ||
|
|
||
| let contains = elements.iter().any(|elem| elem == needle); |
Contributor
There was a problem hiding this comment.
do this with a compare and an any true. maybe keep that you you have for len less than some value?
Member
Author
There was a problem hiding this comment.
i think we'll always falback to https://github.com/apache/arrow-rs/blob/181007df053e9004f7a211f7de086c4bbbd0a9e9/arrow-ord/src/cmp.rs#L395 - don't think it has any performance wins over that implementation
Contributor
There was a problem hiding this comment.
this will use scalar equality not rust primitive type equality and not vectorize
Contributor
|
this is a perf pr |
joseph-isaacs
added
the
action/benchmark-sql
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
joseph-isaacs
added
changelog/performance
Deploying vortex-bench with
|
| Latest commit: |
5790666
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0649193c.vortex-93b.pages.dev |
| Branch Preview URL: | https://db-list-contains-scalar.vortex-93b.pages.dev |
joseph-isaacs
approved these changes
Feb 4, 2026
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
We have horrible scalars so this is best we can do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.