Skip to content

Function to return vtable from an array#7085

Merged
gatesn merged 2 commits intodevelopfrom
ngates/array-vtable-fn
Mar 20, 2026
Merged

Function to return vtable from an array#7085
gatesn merged 2 commits intodevelopfrom
ngates/array-vtable-fn

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Mar 20, 2026

Adds a function to return the vtable from an array.

This is because it better models the future world where Array<V> holds a vtable: V.
After this we need to change the functions on the vtable trait to take &self

gatesn added 2 commits March 20, 2026 11:52
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested a review from joseph-isaacs March 20, 2026 17:02
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 20, 2026

Merging this PR will degrade performance by 12.36%

❌ 2 regressed benchmarks
✅ 1014 untouched benchmarks
⏩ 1522 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bench_many_nulls[0.5] 324.3 µs 360.4 µs -10.02%
Simulation bench_many_nulls[0.9] 463.1 µs 528.4 µs -12.36%

Comparing ngates/array-vtable-fn (46c71bb) with develop (8e1fe29)

Open in CodSpeed

Footnotes

  1. 1522 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn added the changelog/chore A trivial change label Mar 20, 2026
@gatesn gatesn enabled auto-merge (squash) March 20, 2026 17:13
@gatesn gatesn merged commit 0c29fc4 into develop Mar 20, 2026
61 of 63 checks passed
@gatesn gatesn deleted the ngates/array-vtable-fn branch March 20, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants