LazyBuffers: LazyBufferHandle#7091
LazyBuffers: LazyBufferHandle#7091gatesn wants to merge 1 commit intongates/lazy-buffers/slicingfrom
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will degrade performance by 76.84%
Performance Changes
Comparing Footnotes
|
| /// | ||
| /// Returns an error if the segment cannot be loaded or the selection cannot be | ||
| /// applied. | ||
| pub async fn materialize(&self) -> VortexResult<BufferHandle> { |
There was a problem hiding this comment.
FIXME: I think we need to change SegmentSource to take a Vec so we don't end up heap-allocating hundreds of requests. This can flow all the way into the coalesced reader if we need to.

Summary
Closes: #000
Testing