bug fix for ASDI with rotation threshold, small speed gain for frame_derotate, major update of test framework, major fix for bkg_star_proba

[IainHammond]

I need to learn how to use branches.

First up is a bug fix for the case of ASDI in _adimsdi_doublepca. If we have source_xy but no reference cube  (i.e. IFS data with a planet but no cube_ref), an empty reference array is still provided to _project_subtract, causing a crash. This just fixes this case by adding a check for a reference cube.

Part two is me trying to get a small speed up to frame rotation. This was accomplished by removing an unnecessary double array operation when checking for NaNs, and also removing an extra array creation by just reshaping a current one. It's only a couple of seconds faster but it's something.

Finally, we were getting loads of warnings about the tests. Turns out they were a bit behind on updates (Node.js 20 deprecation). Checkout, setup-python, and pre-commit-hooks are all updated to the latest major release and that has fixed everything. The pre-commit is now its own job that runs first and just checks the code, instead of running 16 times (one for each of the 4 python versions, 3 times each, plus the 4 object tests) and will not start the tests unless it passes.

EDIT: Bonus from Monday 30th March, bkg_star_proba has had a major fix. Previously the function could only print a maximum probability of 1% (instead of up to 100%) due to a missing factor of 100. The default units from the input n_dens are now square degrees as that is the default for the models where we get this information from (e.g. Besançon). There is now a unit argument, so it can be changed from "deg" to "arcsec" to give the user the choice of how they want to provide n_dens, and the units used in the calculation are printed.

Enjoy !

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.28%. Comparing base (778923a) to head (f598105).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/vip_hci/stats/bkg_proba.py	7.69%	12 Missing ⚠️
src/vip_hci/psfsub/pca_fullfr.py	0.00%	3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #705       +/-   ##
===========================================
+ Coverage   32.51%   50.28%   +17.76%     
===========================================
  Files          88       88               
  Lines       17048    17058       +10     
===========================================
+ Hits         5543     8577     +3034     
+ Misses      11505     8481     -3024     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[VChristiaens]

Fantastic - well done @IainHammond !