Refactor puppet modules properties

[neomilium]

This commit introduces a new class PuppetModule in order to simplify properties computation.

This new class:

• allows a single name, namespace and the working directory computation
• introduces the given_name property, which is the name the user puts in
  its configuration file
• adds the capability a have a longer namespace (e.g. puppet/modules)

This commit also exposes the options through ModuleSync.options instead
of passing it to almost any methods.

As name and namespace can be confusing in code, so they have been
renamed to repository_name and repository_namespace.

This commit only introduces minor changes on the output of msync: some
single quotes have been added as delimiters for relevant dynamic part of
the messages; and the use of given_name (i.e. user-provided name) when
relevant (e.g. "Syncing 'voxpupuli/puppet-module'").

[ekohl]

Some minor things inline but I like this abstraction. Cleans up a lot.

Of course some bikeshedding: should it be PuppetModule? I know it's used outside of Puppet and nothing inherently ties modulesync to Puppet modules. Perhaps ManagedModule is a better name and in line with managed_modules.yml.

[ekohl]

Of course some bikeshedding: should it be PuppetModule? I know it's used outside of Puppet and nothing inherently ties modulesync to Puppet modules. Perhaps ManagedModule is a better name and in line with managed_modules.yml.

Any thoughts on this part?

[neomilium]

Some minor things inline but I like this abstraction. Cleans up a lot.

Of course some bikeshedding: should it be PuppetModule? I know it's used outside of Puppet and nothing inherently ties modulesync to Puppet modules. Perhaps ManagedModule is a better name and in line with managed_modules.yml.

Yes, ATM it should be PuppetModule right now as there are some specific code to manage Puppet modules. My goal with #206 is to ease maintenance and to make code more generic... but before this step I'm trying to have a more readable and clean code.
So, for sake of consistency, I started with the right name (IMHO) and will try to slit specific code later.

About managed_modules.yml filename, I would like to discuss about it too... but first, I'm focused on improving the code quality/maintainability.

[ekohl]

Looks like a good refactor. 2 more small items, but otherwise 👍

[ekohl]

Thanks! Let's get this in to allow more.

[neomilium]

Ready to merge?

[ekohl]

I shouldn't forget to press the big green button. Kind of important ;)