Open
Conversation
Member
|
@krissik can you please rebase and maybe add a test for this? |
|
Dear @krissik, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
f29edbd to
2a03f66
Compare
Contributor
Author
|
Can someone point me to an example of how to test a fact? |
igalic
suggested changes
Jul 31, 2020
Contributor
Author
|
I will add tests but I do not know how. An example would be helpfull or some documentation. |
Contributor
so, yeah, https://github.com/voxpupuli/puppet-yum/blob/master/spec/unit/facter/yum_package_updates_spec.rb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change regex in
python_versionandpython_releasefacts so it matches python release candidate version (e.g. Python 2.7.16rc1, Python 3.7.3rc1).