-
-
Notifications
You must be signed in to change notification settings - Fork 9k
fix(reactivity): add __v_skip flag to EffectScope to prevent reactive conversion #14359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe changes add a new test case validating effect scope lifecycle behavior when scopes are stored on reactive objects, and introduce a public Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/reactivity/__tests__/effectScope.spec.ts`:
- Around line 383-385: Remove the debug logging from the test by deleting the
console.log call inside the watch callback (the line that logs '-- rs', values)
in the test using watch([() => status.stage], ...); if the output was intended
for assertion, replace it with an appropriate expect assertion against values or
a spy, otherwise simply remove the console.log to avoid noisy test output.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
close #14357
Summary by CodeRabbit
Tests
New Features
✏️ Tip: You can customize this high-level summary in your review settings.