Update: Clarify and update role allowances for td and th elements#563
Update: Clarify and update role allowances for td and th elements#563scottaohara wants to merge 10 commits intogh-pagesfrom
Conversation
This PR covers a few things: 1. clarifies that the mention of "ancestor table" was meant to mean "nearest ancestor table" - re: validator/validator#1304 2. Per feedback / use cases for correcting errant tables, the allowances for td and th elements have been expanded to allow other reasonable roles that developers may need to use.
| <div class="note"> | ||
| <p> | ||
| If a `td` element is a descendant of a `table` element with exposed with a role of `table`, `grid` or `treegrid`, and the `td` is marked as | ||
| `role=none` or `presentation`, then it is advised that the `td` contain an <a data="aria/#dfn-accessibility-child">accessibility child</a> |
There was a problem hiding this comment.
are you using "it is advised" to avoid "SHOULD"? it reads slightly clunky. In particular, the follow-up later "Otherwise, that" should at least be expanded to "Otherwise, it is advised that" or similr
There was a problem hiding this comment.
ditto in the other two places
There was a problem hiding this comment.
could we use "we advise" rather than "it is advised"? and then "Otherwise, we advise that..."
Co-authored-by: Patrick H. Lauke <splintered@gmail.com>
Co-authored-by: Patrick H. Lauke <splintered@gmail.com>
Co-authored-by: Patrick H. Lauke <splintered@gmail.com>
daniel-montalvo
left a comment
daniel-montalvo
left a comment
There was a problem hiding this comment.
The current additions of <a data="aria/#dfn-accessibility-child">accessibility child</a> result in a markup issue.
I suggest you addxref: ["wai-aria-1.2"], to allow for shorthands to ARIA spec, and then just replace the three instances of <a data="aria/#dfn-accessibility-child">accessibility child</a> with simply [=accessibility child=]
I am sorry I cannot commit these suggestions directly but unfortunately with the new github files changed redesigned interface it takes significantly more time for me to do that, so I'm just commenting here.
3 participants
This PR covers a few things:
TODO: need test cases / updated test cases for the updated role allowances.
Preview | Diff