Enhance Encrypt Module to Support Custom Public Keys#723
Open
ALLiDoizCode wants to merge 2 commits intowanderwallet:pre-monorepo-developmentfrom
Open
Enhance Encrypt Module to Support Custom Public Keys#723ALLiDoizCode wants to merge 2 commits intowanderwallet:pre-monorepo-developmentfrom
ALLiDoizCode wants to merge 2 commits intowanderwallet:pre-monorepo-developmentfrom
Conversation
|
@ALLiDoizCode is attempting to deploy a commit to the Community Labs Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
@ALLiDoizCode Thanks for the PR, but I don't see why a wallet, whose main purpose is to manage the user's keys, should provide generic cryptography functionality (not related to the user's keys). I think that belongs to a utility library. Do you have a specific use-case in mind? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
encryptmodule's asymmetric encryption implementation relies solely on the wallet's public key for encryption. This design delegates the responsibility of encrypting data with any alternative public key to the individual project, limiting flexibility.This pull request updates the
encryptmodule to improve its functionality. With this change, the module will now check for a public key in the providedoptionsobject and use it for encryption if one is specified. If no public key is found in theoptionsobject, it will continue to default to the wallet's public key as before.Changes:
encryptmodule to prioritize a public key from theoptionsobject when available.Benefits: