Open
Conversation
Release warrior 4.6.0
Release warrior 4.6.0
| if namespace.sim: | ||
| WarriorCliClass.sim = True | ||
| if namespace.stage_name and not namespace.kafka_system: | ||
| parser.error("argument -stage_name can't be used without argument -kafka_system") |
Contributor
There was a problem hiding this comment.
if kafka_system is not provided, can't we just skip publishing kafka message.
Author
There was a problem hiding this comment.
@ryadaval-warrior the default value for kafka_system is None and if not provided kafka logic will be skipped and it will execute normally.
ryadaval-warrior
previously approved these changes
Jun 4, 2021
ryadaval-warrior
previously approved these changes
Jun 15, 2021
added 2 commits
January 31, 2022 00:06
…ramework_py3 into feature/stage_execution Pulling master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced stage implementation allowing to group two or more steps in a stage and providing an option to control the execution flow dynamically through kafka message.