Skip to content

rust: add support for imported functions#782

Draft
axic wants to merge 11 commits intomasterfrom
rust-host-funcs
Draft

rust: add support for imported functions#782
axic wants to merge 11 commits intomasterfrom
rust-host-funcs

Conversation

@axic
Copy link
Copy Markdown
Member

@axic axic commented Apr 7, 2021

No description provided.

Comment thread lib/fizzy/capi.cpp
}
catch (fizzy::instantiate_error const& e)
{
std::cout << e.what() << std::endl;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These was my error reporting prior to us adding proper support 😅

Comment thread bindings/rust/src/lib.rs
}
}

fn create_function_import_list(
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to figure out what is the best API defining host functions, but at least this semi-finished translation layer works.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.57%. Comparing base (2bd08ab) to head (8763a7f).
⚠️ Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
- Coverage   99.27%   98.57%   -0.71%     
==========================================
  Files          88        2      -86     
  Lines       13296     1053   -12243     
==========================================
- Hits        13200     1038   -12162     
+ Misses         96       15      -81     
Flag Coverage Δ
rust 98.57% <100.00%> (+0.09%) ⬆️
spectests ?
unittests ?
unittests-32 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
bindings/rust/src/lib.rs 98.84% <100.00%> (+0.07%) ⬆️

... and 86 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axic axic force-pushed the rust-host-funcs branch from 65d48e0 to da649a6 Compare April 9, 2021 19:42
@axic axic force-pushed the rust-host-funcs branch from da649a6 to 13ef566 Compare May 23, 2022 21:18
@axic axic changed the base branch from master to rust-test May 23, 2022 21:18
@axic axic mentioned this pull request May 24, 2022
16 tasks
Base automatically changed from rust-test to master May 24, 2022 10:08
@axic axic force-pushed the rust-host-funcs branch 2 times, most recently from aff29d7 to f38b6ea Compare May 27, 2022 15:59
@axic axic force-pushed the rust-host-funcs branch from f38b6ea to 8763a7f Compare June 21, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant