Skip to content

Remove block per https://github.com/web-illinois/illinois_framework_t…#1201

Closed
hpleas wants to merge 1 commit into5.xfrom
hpleas/issue-1162-remove-cookie-banner-includes-from-our-theme-since-they-are-included-in-the-toolkit
Closed

Remove block per https://github.com/web-illinois/illinois_framework_t…#1201
hpleas wants to merge 1 commit into5.xfrom
hpleas/issue-1162-remove-cookie-banner-includes-from-our-theme-since-they-are-included-in-the-toolkit

Conversation

@hpleas
Copy link
Copy Markdown
Contributor

@hpleas hpleas commented Mar 18, 2026

…heme/issues/1162#issuecomment-3998221111

📝 Description

Provide a short summary that describes how the fix is implemented

Fixes # (issue number)


✅ Peer Review Checklist

Reviewers: Please verify the following before approving.

  • The pull request links to the issue it is addressing in the comment and in the "Development" section of the PR
  • There is a short summary that describes how the fix is implemented
  • Verifying work: Verify that the changes made are addressing the linked issue
  • Accessibility: Changes that might impact accessibility are reviewed to work with keyboard navigation and screen readers
  • Responsive: Layout is tested on desktop, tablet, and mobile screens
  • Config changes: Any configuration updates are tested and verified using the Distribution Update import
  • Security: Output is sanitized (using t(), Twig auto-escaping, etc.). No secrects included (API keys, etc.)
  • Cleanliness: All debug code (ksm(), dpm(), console.log) has been removed.
  • Comments: Complex logic is explained inline.
  • Documentation: Any relevant documentation has been updated (this can be a separate issue if needed)

📸 Screenshots / Video (Optional)

If this is a UI change, please attach a screenshot or a quick screen recording of the change in action.

@trubach
Copy link
Copy Markdown
Contributor

trubach commented Apr 21, 2026

Closing - this was addressed in PR #1164

@trubach trubach closed this Apr 21, 2026
@trubach trubach deleted the hpleas/issue-1162-remove-cookie-banner-includes-from-our-theme-since-they-are-included-in-the-toolkit branch April 21, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants