Skip to content

Add a template for rt-content to more easily handle printing body fie…#1216

Merged
trubach merged 10 commits into5.xfrom
robgasc/issue-1215--full-html-source-not-working-https-github-com/web-illinois/illinois_framework_theme/issues/1188-issuecomment-4013885064-robbie
Apr 8, 2026
Merged

Add a template for rt-content to more easily handle printing body fie…#1216
trubach merged 10 commits into5.xfrom
robgasc/issue-1215--full-html-source-not-working-https-github-com/web-illinois/illinois_framework_theme/issues/1188-issuecomment-4013885064-robbie

Conversation

@robgasc
Copy link
Copy Markdown
Contributor

@robgasc robgasc commented Mar 27, 2026

…ld with ease.

📝 Description

This renders the body field with applied text format, and prefers using a rt-content template to do so versus accessing the field direct in rt and needing to work around how text filtering is handled there.

Fixes #1215


✅ Peer Review Checklist

Reviewers: Please verify the following before approving.

  • The pull request links to the issue it is addressing in the comment and in the "Development" section of the PR
  • There is a short summary that describes how the fix is implemented
  • Verifying work: Verify that the changes made are addressing the linked issue
  • Accessibility: Changes that might impact accessibility are reviewed to work with keyboard navigation and screen readers
  • Responsive: Layout is tested on desktop, tablet, and mobile screens
  • Config changes: Any configuration updates are tested and verified using the Distribution Update import
  • Security: Output is sanitized (using t(), Twig auto-escaping, etc.). No secrects included (API keys, etc.)
  • Cleanliness: All debug code (ksm(), dpm(), console.log) has been removed.
  • Comments: Complex logic is explained inline.
  • Documentation: Any relevant documentation has been updated (this can be a separate issue if needed)

📸 Screenshots / Video (Optional)

If this is a UI change, please attach a screenshot or a quick screen recording of the change in action.

@robgasc
Copy link
Copy Markdown
Contributor Author

robgasc commented Apr 1, 2026

In addition to rt. this pr also fixes list collection, and tweaks feature_grouped to not use |raw filter on body. Also needs web-illinois/illinois_framework_core#170 to ensure body field on feature grouped does not show the label.

@tjackson2113 tjackson2113 requested a review from trubach April 1, 2026 16:03
Copy link
Copy Markdown
Contributor

@trubach trubach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment at #1215 (comment)

@robgasc
Copy link
Copy Markdown
Contributor Author

robgasc commented Apr 8, 2026

@trubach This is now updated so that columns will render and the set body format will be applied for Rich Text.

robgasc and others added 3 commits April 8, 2026 08:55
…ing-https-github-com//issues/1188-issuecomment-4013885064-robbie
…github-com//issues/1188-issuecomment-4013885064-robbie' of github.com:web-illinois/illinois_framework_theme into robgasc/issue-1215--full-html-source-not-working-https-github-com//issues/1188-issuecomment-4013885064-robbie
Copy link
Copy Markdown
Contributor

@trubach trubach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and it looks good! Ready to merge!

@trubach trubach merged commit 4ca00cb into 5.x Apr 8, 2026
@trubach trubach deleted the robgasc/issue-1215--full-html-source-not-working-https-github-com/web-illinois/illinois_framework_theme/issues/1188-issuecomment-4013885064-robbie branch April 8, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Full HTML source not working

2 participants