fix: clean windows onboarding changes against main#796
Open
Conversation
3 tasks
web3dev1337
added a commit
that referenced
this pull request
Mar 8, 2026
Cherry-pick the windows onboarding flow from AnrokX PRs #796 and #791 with all review issues fixed: Features ported: - First-run dependency wizard (Git, Node, npm, gh, Claude, Codex) - Setup action service with PowerShell command runner - GitHub CLI device-flow login with code detection - Git identity configuration (name/email) - Diagnostics panel enhancements - Toast notification CSS rewrite - Workspace startup race condition fix (workspaceSystemReady gate) - Desktop launch trace support in bootstrap page Issues fixed from review: - Remove dead `guidance` variable (~60 lines never rendered in template) - Add retention limit (50 runs) to setupActionService Maps (memory leak) - Disable updater plugin instead of empty pubkey (prevents silent update failures) - Keep stderr on non-Windows platforms for debugging (was nulled everywhere) - Document autoCreate behavioral change in workspaceManager - Exclude binary artifacts (zip files) and patch script from cherry-pick Based on work by AnrokX in PRs #796 and #791. Co-Authored-By: AnrokX <anrokx@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainhistory only (clean PR base)Files in scope
client/app.jsclient/index.htmlclient/notifications.jsclient/styles.cssclient/styles/tabs.cssserver/diagnosticsService.jsserver/index.jsserver/setupActionService.jssrc-tauri/src/main.rsCODEBASE_DOCUMENTATION.mdValidation
node --check server/index.jsnode --check server/diagnosticsService.jsnode --check server/setupActionService.jsnode --check client/app.jsnpm run -s test:unit(79 passed, 2 failed)origin/main:tests/unit/sessionRecoveryService.clearAgent.test.jstests/unit/sessionManager.statusCleanup.test.jsNotes
main.