fix(windows): bidirectional pty compat for all conpty.node variants#983
Merged
web3dev1337 merged 1 commit intomainfrom Mar 21, 2026
Merged
fix(windows): bidirectional pty compat for all conpty.node variants#983web3dev1337 merged 1 commit intomainfrom
web3dev1337 merged 1 commit intomainfrom
Conversation
…arg count The runtime compat previously only handled the case where the JS wrapper sent MORE args than the native conpty.node expected (7→6 for startProcess, 6→5 for connect). On some Windows machines, the native binary expects MORE args than the JS sends (e.g. requires useConptyDll as 7th arg). This caused Commander and worktree terminals to fail on those machines. Now handles both directions: - startProcess: 7→6 (strip useConptyDll) AND 6→7 (append false) - connect: 6→5 (strip useConptyDll) AND 5→6 (insert false before callback) - resize/clear/kill: parse expected arg count from usage error, pad or strip Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useConptyDllwhen native doesn't want it)conpty.nodebinary expects MORE args than the JS wrapper sends — the opposite directionUsage: pty.startProcess(file, cols, rows, debug, pipeName, inheritCursor, useConptyDll)startProcess: 7→6 (existing) AND 6→7 (appendfalse)connect: 6→5 (existing) AND 5→6 (insertfalsebefore callback)resize/clear/kill: parses expected arg count from usage error message, pads or strips accordinglyTest plan
Usage: pty.startProcess(...useConptyDll)error🤖 Generated with Claude Code