implemented user configurable world height, cleaned up commits#4102
Open
JurgenKuyper wants to merge 2 commits intowebbukkit:v3.0from
Open
implemented user configurable world height, cleaned up commits#4102JurgenKuyper wants to merge 2 commits intowebbukkit:v3.0from
JurgenKuyper wants to merge 2 commits intowebbukkit:v3.0from
Conversation
minimusubi
reviewed
Apr 11, 2024
minimusubi
left a comment
minimusubi
left a comment
There was a problem hiding this comment.
in general, im personally not a fan of having to configure the world height and negative adjustment per-world in a config file. i believe it would be a better user experience if we could detect the world height automatically. this is where mikeprimm's input would be valuable
| } | ||
| } | ||
| else{ | ||
| worldheight = configuration.getInteger("worldheight", 348); |
There was a problem hiding this comment.
384, not 348 (64 + 320). however, i would caution against this, as it now requires users to manually specify the world height for nether and end worlds
| fillcolor = new Color[worldheight]; /* Color by Y, must be range of total world height, offset by +64*/ | ||
| /* Load defined colors from parameters */ | ||
| for(int i = 0; i < worldheight; i++) { | ||
| fillcolor[i] = configuration.getColor("color" + (i - 64), null); /* need to substract by 64 because Color does not accept <0 indexes*/ |
There was a problem hiding this comment.
i - 64 will be incorrect for end and nether worlds (they still use 0-255)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuation of #4100, now only one commit wrt v3.0