NeoForge support (1.20.6, 1.21.1, 1.21.4) by minimusubi · Pull Request #4183 · webbukkit/dynmap

minimusubi · 2025-01-18T12:48:15Z

Adds support for NeoForge on the three relevant versions:

1.20.6 (last version of 1.20) (untested)
1.21.1 (most mod-supported version of 1.21)
1.21.4 (latest version of 1.21) (untested)

Notes

Updated NeoGradle to 7.0.178
Updated Gradle (and Gradle wrapper) from 8.7 to 8.12 for newer NeoGradle support
Updated fabric-loom from 1.6.11 to 1.9.2 for newer Gradle support

* The fabric-loom upgrade was done based off of 30d6845, but after the recent merges, may not be required

Update Gradle to 8.12

NeffIsBack · 2025-03-16T16:22:41Z

Can confirm at least for All-The-Mods 10 (1.21.1) it works 🎉

NeffIsBack · 2025-03-16T17:11:06Z

Not sure if that is due to this PR, but it crashed the server after ~5mins:

[16März2025 17:51:54.445] [Server thread/ERROR] [net.minecraft.util.thread.BlockableEventLoop/FATAL]: Error executing task on Chunk source main thread executor for minecraft:overworld
net.minecraft.ReportedException: Feature placement
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.level.ChunkMap.lambda$applyStep$19(ChunkMap.java:641) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:148) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.level.ServerChunkCache$MainThreadExecutor.doRunTask(ServerChunkCache.java:559) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.level.ServerChunkCache$MainThreadExecutor.pollTask(ServerChunkCache.java:568) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:132) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.level.ServerChunkCache$MainThreadExecutor.managedBlock(ServerChunkCache.java:533) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.level.ServerChunkCache.getChunk(ServerChunkCache.java:159) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/dynmap@3.7-SNAPSHOT-Dev/org.dynmap.neoforge_1_21_1.NeoForgeMapChunkCache.getLoadedChunk(NeoForgeMapChunkCache.java:41) ~[Dynmap-3.7-SNAPSHOT-neoforge-1.21.1.jar%23618!/:?]
	at TRANSFORMER/dynmap@3.7-SNAPSHOT-Dev/org.dynmap.common.chunk.GenericMapChunkCache.getLoadedChunks(GenericMapChunkCache.java:762) ~[Dynmap-3.7-SNAPSHOT-neoforge-1.21.1.jar%23618!/:?]
	at TRANSFORMER/dynmap@3.7-SNAPSHOT-Dev/org.dynmap.neoforge_1_21_1.NeoForgeServer$1.call(NeoForgeServer.java:433) ~[Dynmap-3.7-SNAPSHOT-neoforge-1.21.1.jar%23618!/:?]
	at TRANSFORMER/dynmap@3.7-SNAPSHOT-Dev/org.dynmap.neoforge_1_21_1.NeoForgeServer$1.call(NeoForgeServer.java:427) ~[Dynmap-3.7-SNAPSHOT-neoforge-1.21.1.jar%23618!/:?]
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) ~[?:?]
	at TRANSFORMER/dynmap@3.7-SNAPSHOT-Dev/org.dynmap.neoforge_1_21_1.NeoForgeServer.tickEvent(NeoForgeServer.java:510) ~[Dynmap-3.7-SNAPSHOT-neoforge-1.21.1.jar%23618!/:?]
	at MC-BOOTSTRAP/net.neoforged.bus/net.neoforged.bus.EventBus.post(EventBus.java:350) ~[bus-8.0.2.jar%2367!/:?]
	at MC-BOOTSTRAP/net.neoforged.bus/net.neoforged.bus.EventBus.post(EventBus.java:315) ~[bus-8.0.2.jar%2367!/:?]
	at TRANSFORMER/neoforge@21.1.133/net.neoforged.neoforge.event.EventHooks.fireServerTickPost(EventHooks.java:1002) ~[neoforge-21.1.133-universal.jar%23512!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:943) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:707) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:267) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]
Caused by: java.lang.NullPointerException: Cannot invoke "org.dynmap.markers.MarkerSet.getDefaultMarkerIcon()" because "markerSet" is null
	at TRANSFORMER/waystones@21.1.13/net.blay09.mods.waystones.compat.DynmapIntegration.createWaystoneMarker(DynmapIntegration.java:122) ~[waystones-neoforge-1.21.1-21.1.13.jar%23879!/:21.1.13]
	at TRANSFORMER/waystones@21.1.13/net.blay09.mods.waystones.compat.DynmapIntegration.addWaystoneMarker(DynmapIntegration.java:52) ~[waystones-neoforge-1.21.1-21.1.13.jar%23879!/:21.1.13]
	at TRANSFORMER/waystones@21.1.13/net.blay09.mods.waystones.compat.DynmapIntegration.lambda$onWaystoneInitialized$0(DynmapIntegration.java:92) ~[waystones-neoforge-1.21.1-21.1.13.jar%23879!/:21.1.13]
	at TRANSFORMER/waystones@21.1.13/net.blay09.mods.waystones.compat.DynmapIntegration.runWhenDynmapIsReady(DynmapIntegration.java:145) ~[waystones-neoforge-1.21.1-21.1.13.jar%23879!/:21.1.13]
	at TRANSFORMER/waystones@21.1.13/net.blay09.mods.waystones.compat.DynmapIntegration.onWaystoneInitialized(DynmapIntegration.java:92) ~[waystones-neoforge-1.21.1-21.1.13.jar%23879!/:21.1.13]
	at TRANSFORMER/balm@21.0.31/net.blay09.mods.balm.neoforge.event.NeoForgeBalmEvents.fireEventHandler(NeoForgeBalmEvents.java:50) ~[balm-neoforge-1.21.1-21.0.31.jar%23558!/:21.0.31]
	at TRANSFORMER/balm@21.0.31/net.blay09.mods.balm.neoforge.event.NeoForgeBalmEvents.lambda$fireEventHandlers$0(NeoForgeBalmEvents.java:44) ~[balm-neoforge-1.21.1-21.0.31.jar%23558!/:21.0.31]
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) ~[?:?]
	at TRANSFORMER/balm@21.0.31/net.blay09.mods.balm.neoforge.event.NeoForgeBalmEvents.fireEventHandlers(NeoForgeBalmEvents.java:44) ~[balm-neoforge-1.21.1-21.0.31.jar%23558!/:21.0.31]
	at TRANSFORMER/balm@21.0.31/net.blay09.mods.balm.neoforge.event.NeoForgeBalmEvents.fireEvent(NeoForgeBalmEvents.java:76) ~[balm-neoforge-1.21.1-21.0.31.jar%23558!/:21.0.31]
	at TRANSFORMER/waystones@21.1.13/net.blay09.mods.waystones.core.WaystoneManagerImpl.addWaystone(WaystoneManagerImpl.java:41) ~[waystones-neoforge-1.21.1-21.1.13.jar%23879!/:21.1.13]
	at TRANSFORMER/waystones@21.1.13/net.blay09.mods.waystones.block.entity.WaystoneBlockEntityBase.initializeWaystone(WaystoneBlockEntityBase.java:206) ~[waystones-neoforge-1.21.1-21.1.13.jar%23879!/:21.1.13]
	at TRANSFORMER/waystones@21.1.13/net.blay09.mods.waystones.worldgen.WaystoneFeature.place(WaystoneFeature.java:51) ~[waystones-neoforge-1.21.1-21.1.13.jar%23879!/:21.1.13]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.world.level.levelgen.feature.Feature.place(Feature.java:168) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.world.level.levelgen.feature.ConfiguredFeature.place(ConfiguredFeature.java:28) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.world.level.levelgen.placement.PlacedFeature.lambda$placeWithContext$4(PlacedFeature.java:54) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) ~[?:?]
	at java.base/java.util.stream.Streams$StreamBuilderImpl.forEachRemaining(Streams.java:411) ~[?:?]
	at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762) ~[?:?]
	at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276) ~[?:?]
	at java.base/java.util.stream.Streams$StreamBuilderImpl.forEachRemaining(Streams.java:411) ~[?:?]
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) ~[?:?]
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) ~[?:?]
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596) ~[?:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.world.level.levelgen.placement.PlacedFeature.placeWithContext(PlacedFeature.java:53) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.world.level.levelgen.placement.PlacedFeature.placeWithBiomeCheck(PlacedFeature.java:42) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.world.level.chunk.ChunkGenerator.applyBiomeDecoration(ChunkGenerator.java:396) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.world.level.chunk.status.ChunkStatusTasks.generateFeatures(ChunkStatusTasks.java:154) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.world.level.chunk.status.ChunkStep.apply(ChunkStep.java:33) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.level.ChunkMap.applyStep(ChunkMap.java:628) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.level.GenerationChunkHolder.applyStep(GenerationChunkHolder.java:64) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.level.ChunkGenerationTask.scheduleChunkInLayer(ChunkGenerationTask.java:143) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.level.ChunkGenerationTask.scheduleLayer(ChunkGenerationTask.java:121) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.level.ChunkGenerationTask.scheduleNextLayer(ChunkGenerationTask.java:74) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.level.ChunkGenerationTask.runUntilWait(ChunkGenerationTask.java:59) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.level.ChunkMap.lambda$runGenerationTask$21(ChunkMap.java:657) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.level.ChunkTaskPriorityQueueSorter.lambda$message$1(ChunkTaskPriorityQueueSorter.java:62) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.util.thread.ProcessorMailbox.pollTask(ProcessorMailbox.java:91) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.util.thread.ProcessorMailbox.pollUntil(ProcessorMailbox.java:146) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.util.thread.ProcessorMailbox.run(ProcessorMailbox.java:102) ~[server-1.21.1-20240808.144430-srg.jar%23511!/:?]
	at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1423) ~[?:?]
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387) ~[?:?]
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1310) ~[?:?]
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1841) ~[?:?]
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1806) ~[?:?]
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188) ~[?:?]
[16März2025 17:51:54.495] [Worker-Main-6/FATAL] [net.neoforged.neoforge.common.NeoForgeMod/]: Preparing crash report with UUID 7cb26769-b196-42f6-a82f-54ef011d7f9a

ckoval7 · 2025-05-20T22:48:53Z

This is what I get with ATM10:
java.lang.NullPointerException: Cannot invoke "org.dynmap.markers.MarkerSet.getDefaultMarkerIcon()" because "markerSet" is null

Full crash report:

crash-2025-05-20_18.41.49-server.txt

ciefa · 2025-05-30T00:06:46Z

Anyone got it working for ATM10?

mikeprimm-mirific and others added 12 commits June 2, 2024 22:37

Start NeoForge 1.20.6

402a835

Merge branch 'v3.0' into neoforge

d78f0a5

feat: NeoForge 1.21.1 support

fb10dfb

Update Gradle to 8.12

fix: fabric-loom for Gradle 8.12

317cd7c

refactor(neoforge 1.21.1): split DynmapPlugin

1c6a9b1

Merge branch 'v3.0' into neoforge

e969d1b

chore(neoforge): bump NeoGradle

61bb05a

style(neoforge 1.21.1): organize imports

4cfc15e

feat(neoforge 1.21.4): add support

530ac77

feat(neoforge 1.20.6): add support

79fb265

chore: update readme

dc5efb5

fix(neoforge): incorrect version requirements

23728ba

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NeoForge support (1.20.6, 1.21.1, 1.21.4)#4183

NeoForge support (1.20.6, 1.21.1, 1.21.4)#4183
minimusubi wants to merge 12 commits intowebbukkit:v3.0from
minimusubi:neoforge

minimusubi commented Jan 18, 2025

Uh oh!

NeffIsBack commented Mar 16, 2025

Uh oh!

NeffIsBack commented Mar 16, 2025

Uh oh!

ckoval7 commented May 20, 2025

Uh oh!

ciefa commented May 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

minimusubi commented Jan 18, 2025

Notes

Uh oh!

NeffIsBack commented Mar 16, 2025

Uh oh!

NeffIsBack commented Mar 16, 2025

Uh oh!

ckoval7 commented May 20, 2025

Uh oh!

ciefa commented May 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants