Conversation
sorvell
changed the title
added 2 commits
February 27, 2025 05:34
Collaborator
Author
|
To prevent future issues with conflicting with native implementations, let's consider offering a version of this that's more of a ponyfill. For example: pony(document).createElement(tag, {customElements})
pony(element).customElements
pony(element).attachShadow({mode: 'open', customElements})This might be fairly annoying in practice and there are some options:
|
| } | ||
|
|
||
| interface ShadowRoot { | ||
| readonly ['customElementRegistry']: CustomElementRegistry | null; |
Collaborator
There was a problem hiding this comment.
It'd be nice for reviewing and future readers to leave links to where public APIs are specced. I think this link would be good here: https://dom.spec.whatwg.org/#dom-documentorshadowroot-customelementregistry
| // > root avoids this. | ||
| const scopeForElement = new WeakMap<Node, Element | ShadowRoot>(); | ||
|
|
||
| const registryForElement = new WeakMap< |
Collaborator
There was a problem hiding this comment.
Maybe choose a more descriptive name or add a comment. Maybe setRegistryForSubtree?
Also, does this implement a spec operation? If so, it'd be useful to have a link.
packages/scoped-custom-element-registry/src/scoped-custom-element-registry.ts
Outdated
Show resolved
Hide resolved
| const {tagName, CustomElementClass} = getTestElement(); | ||
| registry.define(tagName, CustomElementClass); | ||
| shadowRoot.innerHTML = `<${tagName}></${tagName}><div></div>`; | ||
| registry.initialize(shadowRoot); |
Collaborator
There was a problem hiding this comment.
what about initializing a non-shadow root parent, or initializing a subtree where some elements already have registries?
packages/scoped-custom-element-registry/src/scoped-custom-element-registry.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Justin Fagnani <justinfagnani@google.com>
Co-authored-by: Justin Fagnani <justinfagnani@google.com>
Co-authored-by: Justin Fagnani <justinfagnani@google.com>
Co-authored-by: Justin Fagnani <justinfagnani@google.com>
Co-authored-by: Justin Fagnani <justinfagnani@google.com>
* status reported in CustomElementRegistryPolyfill.inUse * support DSD null registries via host attribute `polyfill-shadowrootcustomelementregistry` * add additional tests to address feedback * re-order some tests * tracked scoped context now only supports valid customElementRegistry values * added ability to test native impl on Safari + bail outs for known bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #603
New proposal: whatwg/html#10854