fix(tooling): replace Rollup with Webpack for bundling of meetings widget#617
Open
Riteshfyi wants to merge 10 commits intowebex:nextfrom
Open
fix(tooling): replace Rollup with Webpack for bundling of meetings widget#617Riteshfyi wants to merge 10 commits intowebex:nextfrom
Riteshfyi wants to merge 10 commits intowebex:nextfrom
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Shreyas281299
approved these changes
Feb 12, 2026
| "demo:build": "webpack ./demo/App.jsx --mode production", | ||
| "build:src": "yarn clean:dist && webpack ./src/index.js --env buildType=dist --mode production", | ||
| "demo:serve": "webpack serve ./demo/App.jsx --env buildType=demo --mode development", | ||
| "demo:build": "webpack ./demo/App.jsx --env buildType=demo --mode production", |
Contributor
There was a problem hiding this comment.
Based on the webpack config I feel here the mode should be development
Suggested change
| "demo:build": "webpack ./demo/App.jsx --env buildType=demo --mode production", | |
| "demo:build": "webpack ./demo/App.jsx --env buildType=demo --mode development", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES #https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-767471
This pull request addresses
Removes rollup & moves to webpack for the bundling of meetings widget.
by making the following changes
By Removing rollup config and Updating the webpack.config.js & package.json.
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.