Skip to content

fix(tooling): replace Rollup with Webpack for bundling of meetings widget#617

Open
Riteshfyi wants to merge 10 commits intowebex:nextfrom
Riteshfyi:wp
Open

fix(tooling): replace Rollup with Webpack for bundling of meetings widget#617
Riteshfyi wants to merge 10 commits intowebex:nextfrom
Riteshfyi:wp

Conversation

@Riteshfyi
Copy link
Contributor

COMPLETES #https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-767471

This pull request addresses

Removes rollup & moves to webpack for the bundling of meetings widget.

by making the following changes

By Removing rollup config and Updating the webpack.config.js & package.json.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done locally with samples, then tried consuming from another demo project.
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Cursor
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation
    • Tooling

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • [] I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

@Shreyas281299 Shreyas281299 added the validated Indicates that the PR is ready for actions label Feb 9, 2026
@Riteshfyi Riteshfyi changed the title fix(tooling) : replace Rollup with Webpack for bundling of meetings widget fix(tooling): replace Rollup with Webpack for bundling of meetings widget Feb 9, 2026
@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-617.d1b38q61t1z947.amplifyapp.com

"demo:build": "webpack ./demo/App.jsx --mode production",
"build:src": "yarn clean:dist && webpack ./src/index.js --env buildType=dist --mode production",
"demo:serve": "webpack serve ./demo/App.jsx --env buildType=demo --mode development",
"demo:build": "webpack ./demo/App.jsx --env buildType=demo --mode production",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the webpack config I feel here the mode should be development

Suggested change
"demo:build": "webpack ./demo/App.jsx --env buildType=demo --mode production",
"demo:build": "webpack ./demo/App.jsx --env buildType=demo --mode development",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated Indicates that the PR is ready for actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants