fix(tooling): remove wdio & upgrade meeting widget to playwright#628
fix(tooling): remove wdio & upgrade meeting widget to playwright#628Riteshfyi wants to merge 15 commits intowebex:nextfrom
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Riteshfyi
changed the title
akulakum
added
validated
Riteshfyi
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52c36927e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "release:dry-run": "semantic-release --dry-run", | ||
| "start": "npm run demo:serve", | ||
| "test:e2e": "npm run demo:build && wdio wdio.conf.js", | ||
| "test:e2e": "npm run demo:build && yarn playwright test --project='Meetings Setup' --project='Meetings Widget Test'", |
There was a problem hiding this comment.
test:e2e invokes Playwright with --project='Meetings Setup', but the setup project defined in playwright.config.ts is named OAuth: Get Meeting Access Token (line 76). Since Playwright resolves --project by exact project name, this command fails before tests run, which means the e2e_test_meetings workflow path (.github/workflows/pull-request.yml, Test E2E) cannot execute the migrated meetings suite.
Useful? React with 👍 / 👎.
| this.unmuteAudioBtn = this.controls.getByRole('button', {name: 'Unmute'}); | ||
| this.muteVideoBtn = this.controls.getByRole('button', {name: 'Stop video'}); | ||
| this.unmuteVideoBtn = this.controls.getByRole('button', {name: 'Start video'}); | ||
| this.joinMeetingBtn = this.controls.getByRole('button', {name: /^(Muted, video off|Unmuted, video on)$/}); |
There was a problem hiding this comment.
The new locator only matches a button named /^(Muted, video off|Unmuted, video on)$/, but the meeting widget code still identifies the pre-join control as button[aria-label="Join meeting"] (packages/@webex/widgets/src/widgets/WebexMeetings/WebexMeetings.jsx), and the prior E2E test also targeted “Join meeting”; in that pre-join state joinMeetingBtn.click() in both suites cannot resolve an element, so the tests fail before joining.
Useful? React with 👍 / 👎.
rarajes2
changed the title
3 participants
COMPLETES #https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-772628
This pull request addresses
Removes Wdio E2E Tests & moves to playwright for meetings widget.
by making the following changes
converting previous tests to typescrip & updating them for palywright
Change Type
The following scenarios were tested
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.