Conversation
AlbertWeichselbraun
commented
Nov 18, 2025
AlbertWeichselbraun
commented
- improve ruff configuration to replace tox (quicker static code analysis)
- adjust CI settings
- upgraded development dependencies
- remove Python 3.10 support due to EOL
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the CI/CD pipeline by replacing tox with ruff for faster static code analysis, updates development dependencies, removes Python 3.9 support (note: the PR description says 3.10, but the changes show 3.9 was removed), and improves code formatting consistency across the codebase.
- Replaced tox-based linting with ruff configuration for faster static analysis
- Updated CI workflow to use
uvfor building and testing instead of tox - Upgraded multiple development dependencies to newer versions
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tox.ini | Removed tox configuration entirely in favor of ruff |
| pyproject.toml | Updated Python version requirements (3.10+), upgraded dev dependencies, added comprehensive ruff linting rules |
| .github/workflows/python-package.yml | Modified CI to use uv and ruff instead of tox |
| publish.sh | Changed build system from poetry to uv |
| Multiple .py files | Applied code formatting improvements (trailing commas, docstring formatting, blank lines) |
Comments suppressed due to low confidence (2)
pyproject.toml:12
- Remove trailing whitespace on this blank line.
]
pyproject.toml:12
- Remove trailing whitespace at the end of this line.
]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "RSE", "SLOT", "TID", "TC", "C90", "PERF", "E", "W", | ||
| "FURB", "RUF", "TRY", "YTT", |
There was a problem hiding this comment.
Line 103 ends with a trailing comma but line 104 continues the list without proper formatting. Consider placing all items on line 103 on separate lines for better readability, or consolidate them properly on line 104.
| "RSE", "SLOT", "TID", "TC", "C90", "PERF", "E", "W", | |
| "FURB", "RUF", "TRY", "YTT", | |
| "RSE", "SLOT", "TID", "TC", "C90", "PERF", "E", "W" | |
| , "FURB", "RUF", "TRY", "YTT", |
| def benchmark(args, source_list): | ||
| """ | ||
| Run the benchmark. | ||
| """Run the benchmark. | ||
|
|
||
| Args: | ||
| args: command line arguments | ||
| source_list: a list of URLs to benchmark. | ||
| """ | ||
|
|
||
| """ |
There was a problem hiding this comment.
The closing triple quotes for the docstring are in the wrong position. They should come immediately after the documentation ends, not on a separate line after Args section. Move the closing \"\"\" to line 328 (after 'source_list: a list of URLs to benchmark.').
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
